Tweak solari world cache#21776
Merged
alice-i-cecile merged 2 commits intobevyengine:mainfrom Nov 21, 2025
Merged
Conversation
JMS55
added
A-Rendering
atlv24
approved these changes
Nov 7, 2025
JMS55
added
the
S-Needs-Review
SparkyPotato
approved these changes
Nov 7, 2025
JMS55
added
S-Ready-For-Final-Review
HugoPeters1024
approved these changes
Nov 15, 2025
Contributor
HugoPeters1024
left a comment
HugoPeters1024
left a comment
There was a problem hiding this comment.
I can attest from experience that 1024 is indeed far too large a work group size for raytracing workloads. Although the optimal is also hardware dependent, 64 is a reasonable default
beicause
pushed a commit
to beicause/bevy
that referenced
this pull request
Nov 26, 2025
* Make the world cache transition LODs faster. On big scenes like bistro, we had way too many small cells before. * Limit world cache GI rays to 4m, we save a ton of time and improve stability by not sampling super far away cells. * Switch world cache active cell update workgroup size from 1024 -> 64. Using large workgroup sizes for RT work kills occupancy. World cache sample_radiance time goes from 1.42ms to 0.09ms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
World cache sample_radiance time goes from 1.42ms to 0.09ms.