Skip to content

Make LoadContext::path return an AssetPath instead of std::path::Path.#21713

Merged
alice-i-cecile merged 5 commits intobevyengine:mainfrom
andriyDev:remove-load-context-path
Nov 3, 2025
Merged

Make LoadContext::path return an AssetPath instead of std::path::Path.#21713
alice-i-cecile merged 5 commits intobevyengine:mainfrom
andriyDev:remove-load-context-path

Conversation

@andriyDev
Copy link
Copy Markdown
Contributor

@andriyDev andriyDev commented Nov 1, 2025

Objective

Solution

  • Make LoadContext::path return an AssetPath and remove LoadContext::asset_path.

@andriyDev andriyDev added D-Trivial Nice and easy! A great choice to get started with Bevy A-Assets Load files from disk to use for things like images, models, and sounds C-Usability A targeted quality-of-life change that makes Bevy easier to use M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Nov 1, 2025
@andriyDev andriyDev added this to the 0.18 milestone Nov 1, 2025
mockersf
mockersf reviewed Nov 1, 2025
View reviewed changes
@andriyDev andriyDev force-pushed the remove-load-context-path branch from a230fe0 to ca0f40b Compare November 1, 2025 19:27
@andriyDev andriyDev force-pushed the remove-load-context-path branch from 7486c81 to 219d62f Compare November 1, 2025 20:10
@andriyDev andriyDev requested a review from mockersf November 1, 2025 20:35
@andriyDev andriyDev force-pushed the remove-load-context-path branch from 219d62f to 5bcf537 Compare November 2, 2025 19:07
@andriyDev andriyDev added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Nov 3, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Nov 3, 2025
Merged via the queue into bevyengine:main with commit 8e24209 Nov 3, 2025
38 checks passed
@andriyDev andriyDev mentioned this pull request Nov 5, 2025
Merged
@andriyDev andriyDev deleted the remove-load-context-path branch November 5, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mockersf mockersf Awaiting requested review from mockersf

1 more reviewer

@kristoff3r kristoff3r kristoff3r approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Assets Load files from disk to use for things like images, models, and sounds C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

0.18

Development

Successfully merging this pull request may close these issues.

4 participants

@andriyDev @kristoff3r @mockersf @alice-i-cecile