handle panics in required component constructors#20933
Draft
janis-bhm wants to merge 4 commits intobevyengine:mainfrom
Draft
handle panics in required component constructors#20933janis-bhm wants to merge 4 commits intobevyengine:mainfrom
janis-bhm wants to merge 4 commits intobevyengine:mainfrom
Conversation
janis-bhm
changed the title
alice-i-cecile
added
C-Bug
Contributor
|
The approach of the resulting entity containing all components except the ones that panicked seems correct to me. That said, the bundle insertion should then re-throw the panic or call the default error handler instead of silently swallowing the error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
fix #20368
Solution
catch panics in required component constructors, then move archetypes if necessary.
this is a PoC kind of PR because I want to know if this is even the right approach to the issue.
Testing
skifire's example works for inserting components and passes miri. still need to fix
spawn_non_existentand consider hooks/observers, clean up code, double check safety.