TilemapChunk single quad; TileData (color/visibility)#19924
Merged
alice-i-cecile merged 6 commits intobevyengine:mainfrom Jul 17, 2025
Merged
TilemapChunk single quad; TileData (color/visibility)#19924alice-i-cecile merged 6 commits intobevyengine:mainfrom
alice-i-cecile merged 6 commits intobevyengine:mainfrom
Conversation
058304a to
edbc343
Compare
Contributor
|
It looks like your PR has been selected for a highlight in the next release blog post, but you didn't provide a release note. Please review the instructions for writing release notes, then expand or revise the content in the release notes directory to showcase your changes. |
edbc343 to
5e026ef
Compare
copygirl
reviewed
Jul 9, 2025
aa512c7 to
606bcb4
Compare
IceSentry
reviewed
Jul 13, 2025
IceSentry
approved these changes
Jul 13, 2025
606bcb4 to
e9c1e1a
Compare
atlv24
reviewed
Jul 14, 2025
crates/bevy_sprite/src/tilemap_chunk/tilemap_chunk_material.wgsl
Outdated
Show resolved
Hide resolved
alice-i-cecile
requested changes
Jul 16, 2025
Member
alice-i-cecile
left a comment
There was a problem hiding this comment.
Core idea is good, but needs more docs :) The default color choice is classic bikeshedding; feel free to leave it as white if you think that's best.
Once that's done I'll test it locally then approve.
alice-i-cecile
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Testing