Skip to content

optimize ktx2 level data concatenation#19845

Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom
atlv24:ad/optimize-ktx2
Jun 29, 2025
Merged

optimize ktx2 level data concatenation#19845
alice-i-cecile merged 1 commit intobevyengine:mainfrom
atlv24:ad/optimize-ktx2

Conversation

@atlv24
Copy link
Copy Markdown
Contributor

@atlv24 atlv24 commented Jun 28, 2025

Objective

Solution

  • reserve and extend

Testing

  • ran a few examples that load ktx2 images, like ssr. looks fine

Future work

  • fast path logic to skip the reading into different vecs and just read it all in one go into the final buffer instead
  • as above, but directly into gpu staging buffer perhaps

@atlv24 atlv24 added A-Rendering Drawing game state to the screen D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jun 28, 2025
@atlv24 atlv24 added the C-Performance A change motivated by improving speed, memory usage or compile times label Jun 28, 2025
@atlv24 atlv24 added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jun 28, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 29, 2025
Merged via the queue into bevyengine:main with commit a8bb208 Jun 29, 2025
43 checks passed
@atlv24 atlv24 deleted the ad/optimize-ktx2 branch July 23, 2025 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Performance A change motivated by improving speed, memory usage or compile times D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants