force unclipped depth emu on webgpu#19785
Closed
robtfm wants to merge 2 commits intobevyengine:mainfrom
Closed
Conversation
Jondolf
reviewed
Jun 23, 2025
Co-authored-by: Joona Aalto <[email protected]>
alice-i-cecile
added
C-Bug
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
I'd prefer to open a bug upstream and link it here (and in the code) before merging this. Fixes seems very sensible though.
6 tasks
Contributor
|
Superseded by gfx-rs/wgpu#7841 And I'll try to get us a backport patch release |
janhohenheim
added
the
S-Nominated-To-Close
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
fixes #19626
Solution
it seems like on webgpu the render device may report DEPTH_CLIP_CONTROL without actually supporting it, so we force emulated mode for webgpu.