Open
Conversation
Member
We should try and fix this.
Renderer test if we're going to be doing rendering and screenshots. Like you say, gltf loading should be tested purely in headless code. |
GltfLoaderSettings::override_sampler and mipmap rendering
Contributor
Author
|
Test has been redone to focus on rendering - glTF testing is now just a bonus. Also added CI support. In the longer-term I'm guessing this test should be redone as BSN scenes, and the glTF part would be split off and made headless. But I'm hoping the current choices are acceptable for the short-term. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Add a test for mipmap filters, and as a bonus test
GltfLoaderSettings::override_sampler. Neither of these are covered by current tests or examples.Solution
gltf_override_sampler.mp4
The test supports CI screenshots, although I haven't added it to the CI config.
Problems
It's currently broken.
GltfLoaderSettings::override_sampler.faefb8dd.Combining two tests into one is debatable.
GltfLoaderSettings::override_sampleris convenient and provides a test case for Gltf assets do not reload correctly #18267.CI screenshot boilerplate.
testbed/helpers.rs.Testing
Tested on Win10/Nvidia, across Desktop/Vulkan, Chrome/WebGL, Chrome/WebGPU.