Skip to content

Use desired language in migration guide template#18576

Merged
alice-i-cecile merged 4 commits intobevyengine:mainfrom
alice-i-cecile:migration-guide-boilerplate
Mar 28, 2025
Merged

Use desired language in migration guide template#18576
alice-i-cecile merged 4 commits intobevyengine:mainfrom
alice-i-cecile:migration-guide-boilerplate

Conversation

@alice-i-cecile
Copy link
Member

Objective

Both reading and writing migration guides is easier when the language is standardized.

However, migration guide authors don't have clear guidelines for the tone and phrasing to use.

Solution

Communicate this information to authors by creating stub text with a clear and polite standard style.

We could instead write a style guide, but turning style guides into a writing style is slower and much harder than simply filling in the blanks. While style guides are a good fit for more free-form writing, they don't work well for the very mechanical and dry migration guides.

@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation A-Meta About the project itself D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Mar 28, 2025
@alice-i-cecile alice-i-cecile added this to the 0.17 milestone Mar 28, 2025
Co-authored-by: Miles Silberling-Cook <[email protected]>
- Make sure it's searchable by directly naming the types and methods involved.
- Use backticks for types, methods and modules (e.g. `Vec<T>` or `core::mem::swap`).
- Use bullet points to explain complex changes.
- Avoid headings. If you must, use only level-two headings.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unrelated to this PR, but I though @NthTensor said this would be handled with tooling. So we don't impose any heading level, the user start using H1, then H2, etc. and the export/import tool will convert to the proper level. The only limit we should impose is "don't use more than X levels" (I think it was worded like that at some point).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The markdown linter wants us to use level-2 because of the title in the front matter. No idea how to change that.

Copy link
Contributor

@Pnoenix Pnoenix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look fine. Maybe add another file or a section in here, that showcases what a complete migration guide file looks like?

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Mar 28, 2025
@alice-i-cecile
Copy link
Member Author

These changes look fine. Maybe add another file or a section in here, that showcases what a complete migration guide file looks like?

In most cases, looking at sibling migration guides will be best for this :)

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Mar 28, 2025
Merged via the queue into bevyengine:main with commit 4a31d8e Mar 28, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Meta About the project itself C-Docs An addition or correction to our documentation D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants