Remove Image::from_buffer name argument (only present in debug "dds" builds)#18538
Merged
alice-i-cecile merged 3 commits intobevyengine:mainfrom Mar 25, 2025
Merged
Conversation
brianreavis
changed the title
name argument (only present in debug "dds" builds)
brianreavis
added
C-Usability
IceSentry
approved these changes
Mar 25, 2025
Contributor
IceSentry
left a comment
IceSentry
left a comment
There was a problem hiding this comment.
Assuming CI is fixed LGTM
brianreavis
added
the
S-Needs-Review
alice-i-cecile
approved these changes
Mar 25, 2025
alice-i-cecile
added
S-Ready-For-Final-Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Image::from_buffer's public signature changes if debug assertions are enabled #17891Solution
The
nameargument could either be made permanent (by removing the#[cfg(...)]condition) or eliminated entirely. I opted to remove it, as debugging a specific DDS texture edge case in GLTF files doesn't seem necessary, and there isn't any other foreseeable need to have it.Migration Guide
Image::from_buffer()no longer has anameargument that's only present in debug builds when the"dds"feature is enabled. If you happen to pass a name, remove it.