Conversation
|
(I assigned the "bug" label because I would expect that to work 😄 ) There are more line separators, but with full unicode support and support for non-latin languages I think this might become super complex. Maybe there are layouting crates for displaying text that handle all this properly already? Your patch seems good to me so far, I am just concerned that in order to deal with text properly a LOT of things need to be in place. I think supporting |
|
Yeah, I totally agree. Text handling IS super complicated. Maybe we can just merge this one and open a new issue "Proper Text support" or something along the lines. Unfortunately, I'm not really experienced with string/text handling in rust and dont know which crates exist out there either. |
|
ab_glyph (the text library we use) has a simple paragraph layout example (which does use line_gap): We should probably also use that. This does seem like a good start and I'm fine making "full multiline support" an iterative process. I'll give this a full review soon. |
|
I'm going to merge this for now. Its a usability win and we can sort out line height later. |
See #182 . Since @karroffel assigned the
Bugtag to it I tried to find the cause for it and develop a fix.Some open questions:
scaled_font.line_gap()to the calculation?\n(or have a similar function)?LTR,RTL, etc. ?)