remove unsound DerefMut impls from EntityHashMap/EntityHashSet#17450
Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom Jan 20, 2025
Merged
Conversation
Victoronz
added
C-Bug
alice-i-cecile
approved these changes
Jan 20, 2025
alice-i-cecile
added
S-Ready-For-Final-Review
viridia
approved these changes
Jan 20, 2025
BenjaminBrienen
approved these changes
Jan 20, 2025
Contributor
BenjaminBrienen
left a comment
BenjaminBrienen
left a comment
There was a problem hiding this comment.
Should we have more code coverage using mem::swap so that miri can catch this?
Contributor
Author
I don't think this is tenable via code coverage, since what we'd need to test is an absence of an API, not how the present one behaves. |
mrchantey
pushed a commit
to mrchantey/bevy
that referenced
this pull request
Feb 4, 2025
…evyengine#17450) # Objective Noticed while doing bevyengine#17449, I had left these `DerefMut` impls in. Obtaining mutable references to those inner iterator types allows for `mem::swap`, which can be used to swap an incorrectly behaving instance into the wrappers. ## Solution Remove them!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Noticed while doing #17449, I had left these
DerefMutimpls in.Obtaining mutable references to those inner iterator types allows for
mem::swap, which can be used to swap an incorrectly behaving instance into the wrappers.Solution
Remove them!