Merged
Conversation
alice-i-cecile
added
X-Needs-SME
MrGVSV
reviewed
Jan 19, 2025
BenjaminBrienen
added
the
D-Straightforward
This reverts commit 58bb7fd.
Member
Author
|
I removed the |
alice-i-cecile
approved these changes
Jan 20, 2025
alice-i-cecile
added
the
M-Migration-Guide
Contributor
|
It looks like your PR is a breaking change, but you didn't provide a migration guide. Could you add some context on what users should update when this change get released in a new version of Bevy? |
alice-i-cecile
added
X-Blessed
Member
|
I like this: I think it's a good compromise and I appreciate that the two terms are related. |
Carter0
approved these changes
Jan 20, 2025
Contributor
Carter0
left a comment
Carter0
left a comment
There was a problem hiding this comment.
It seems our bikes have been successfully shed.
alice-i-cecile
added
S-Ready-For-Final-Review
viridia
approved these changes
Jan 20, 2025
mrchantey
pushed a commit
to mrchantey/bevy
that referenced
this pull request
Feb 4, 2025
Fixes bevyengine#17412 ## Objective `Parent` uses the "has a X" naming convention. There is increasing sentiment that we should use the "is a X" naming convention for relationships (following bevyengine#17398). This leaves `Children` as-is because there is prevailing sentiment that `Children` is clearer than `ParentOf` in many cases (especially when treating it like a collection). This renames `Parent` to `ChildOf`. This is just the implementation PR. To discuss the path forward, do so in bevyengine#17412. ## Migration Guide - The `Parent` component has been renamed to `ChildOf`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17412
Objective
Parentuses the "has a X" naming convention. There is increasing sentiment that we should use the "is a X" naming convention for relationships (following #17398). This leavesChildrenas-is because there is prevailing sentiment thatChildrenis clearer thanParentOfin many cases (especially when treating it like a collection).This renames
ParenttoChildOf.This is just the implementation PR. To discuss the path forward, do so in #17412.
Migration Guide
Parentcomponent has been renamed toChildOf.