Revert "Fix sprite performance regression since retained render world (#17078)"#17123
Merged
cart merged 1 commit intobevyengine:mainfrom Jan 4, 2025
Merged
Revert "Fix sprite performance regression since retained render world (#17078)"#17123cart merged 1 commit intobevyengine:mainfrom
cart merged 1 commit intobevyengine:mainfrom
Conversation
…bevyengine#17078)" This reverts commit fd330c8.
tychedelia
approved these changes
Jan 3, 2025
BenjaminBrienen
approved these changes
Jan 3, 2025
BenjaminBrienen
added
C-Bug
mrchantey
pushed a commit
to mrchantey/bevy
that referenced
this pull request
Feb 4, 2025
…bevyengine#17078)" (bevyengine#17123) # Objective Fixes bevyengine#17098 It seems that it's not totally obvious how to fix this, but that reverting might be part of the solution anyway. Let's get the repo back into a working state. ## Solution Revert the [recent optimization](bevyengine#17078) that broke "many-to-one main->render world entities" for 2d. ## Testing `cargo run --example text2d` `cargo run --example sprite_slice`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #17098
It seems that it's not totally obvious how to fix this, but that reverting might be part of the solution anyway.
Let's get the repo back into a working state.
Solution
Revert the recent optimization that broke "many-to-one main->render world entities" for 2d.
Testing
cargo run --example text2dcargo run --example sprite_slice