Fix inaccurate comment in custom_ui_material.wgsl shader#16846
Fix inaccurate comment in custom_ui_material.wgsl shader#16846alice-i-cecile merged 2 commits intobevyengine:mainfrom
Conversation
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
alice-i-cecile
changed the title
alice-i-cecile
added
D-Trivial
There was a problem hiding this comment.
This is an improvement, but to me it sounds like it is claiming some responsibility in the shader for stuff that is happening in rust code in the example.
The shader is just responsible for drawing the bar according to those material properties that are modified there.
This distinction is sort of relevant to #16829 actually, because this sort of animation could be done in the shader, and people probably want to know how to do that, but that's not what's going on here at the moment.
So it's better to describe as "The shader draws a progress bar in accordance with the data from the game/rust side of the game"? |
alice-i-cecile
added
S-Waiting-on-Author
|
Maybe something like |
alice-i-cecile
added
S-Ready-For-Final-Review
…16846) # Objective - Modify a comment in the shader file to describe what the shader actually does - Fixes bevyengine#16830 ## Solution - Changed the comment. ## Testing - Testing is not relevant to fixing comments (as long as the comment is accurate) --------- Co-authored-by: Freya Pines <[email protected]> Co-authored-by: Freya Pines <[email protected]>
…16846) # Objective - Modify a comment in the shader file to describe what the shader actually does - Fixes bevyengine#16830 ## Solution - Changed the comment. ## Testing - Testing is not relevant to fixing comments (as long as the comment is accurate) --------- Co-authored-by: Freya Pines <[email protected]> Co-authored-by: Freya Pines <[email protected]>
4 participants
Objective
custom_ui_material.wgslare outdated #16830Solution
Testing