Feature gate is_polygon_simple behind the alloc feature.#16739
Merged
alice-i-cecile merged 2 commits intobevyengine:mainfrom Dec 10, 2024
Merged
Feature gate is_polygon_simple behind the alloc feature.#16739alice-i-cecile merged 2 commits intobevyengine:mainfrom
is_polygon_simple behind the alloc feature.#16739alice-i-cecile merged 2 commits intobevyengine:mainfrom
Conversation
CI was failing because `bevy_math` no longer compiled with `libcore`. This was due to PR bevyengine#15981. This commit fixes the issue by moving the applicable functionality behind `#[cfg(feature = "alloc")]`.
pcwalton
added
P-Regression
bushrat011899
approved these changes
Dec 10, 2024
Contributor
bushrat011899
left a comment
bushrat011899
left a comment
There was a problem hiding this comment.
Thanks for fixing this one! I'm surprised it managed to sneak in, I guess the full CI isn't run during the merging perhaps? Regardless, this shouldn't be a problem going forward anyway, since every other crate in Bevy will require alloc, so the only new feature will be std, which should hopefully be less frequent.
alice-i-cecile
added
S-Ready-For-Final-Review
BenjaminBrienen
approved these changes
Dec 10, 2024
BD103
pushed a commit
to BD103/bevy
that referenced
this pull request
Dec 10, 2024
…ine#16739) CI was failing because `bevy_math` no longer compiled with `libcore`. This was due to PR bevyengine#15981. This commit fixes the issue by moving the applicable functionality behind `#[cfg(feature = "alloc")]`.
ecoskey
pushed a commit
to ecoskey/bevy
that referenced
this pull request
Jan 6, 2025
…ine#16739) CI was failing because `bevy_math` no longer compiled with `libcore`. This was due to PR bevyengine#15981. This commit fixes the issue by moving the applicable functionality behind `#[cfg(feature = "alloc")]`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI was failing because
bevy_mathno longer compiled withlibcore. This was due to PR #15981. This commit fixes the issue by moving the applicable functionality behind#[cfg(feature = "alloc")].