Use multidraw for shadows when GPU culling is in use.#16692
Merged
alice-i-cecile merged 2 commits intobevyengine:mainfrom Dec 10, 2024
Merged
Use multidraw for shadows when GPU culling is in use.#16692alice-i-cecile merged 2 commits intobevyengine:mainfrom
alice-i-cecile merged 2 commits intobevyengine:mainfrom
Conversation
This patch makes shadows use multidraw when the camera they'll be drawn to has the `GpuCulling` component. This results in a significant reduction in drawcalls; Bistro Exterior drops to 3 drawcalls for each shadow cascade. Note that PR bevyengine#16670 will remove the `GpuCulling` component, making shadows automatically use multidraw. Beware of that when testing this patch; before bevyengine#16670 lands, you'll need to manually add `GpuCulling` to your camera in order to see any performance benefits.
pcwalton
added
A-Rendering
kristoff3r
approved these changes
Dec 6, 2024
Contributor
kristoff3r
left a comment
kristoff3r
left a comment
There was a problem hiding this comment.
Code LGTM, tested a few lighting/shadow examples with/without GpuCulling.
JMS55
approved these changes
Dec 7, 2024
JMS55
added
S-Ready-For-Final-Review
Member
|
Testing the example runs before merging <3 |
Contributor
Author
|
@alice-i-cecile Success |
BD103
pushed a commit
to BD103/bevy
that referenced
this pull request
Dec 10, 2024
This patch makes shadows use multidraw when the camera they'll be drawn to has the `GpuCulling` component. This results in a significant reduction in drawcalls; Bistro Exterior drops to 3 drawcalls for each shadow cascade. Note that PR bevyengine#16670 will remove the `GpuCulling` component, making shadows automatically use multidraw. Beware of that when testing this patch; before bevyengine#16670 lands, you'll need to manually add `GpuCulling` to your camera in order to see any performance benefits.
ecoskey
pushed a commit
to ecoskey/bevy
that referenced
this pull request
Jan 6, 2025
This patch makes shadows use multidraw when the camera they'll be drawn to has the `GpuCulling` component. This results in a significant reduction in drawcalls; Bistro Exterior drops to 3 drawcalls for each shadow cascade. Note that PR bevyengine#16670 will remove the `GpuCulling` component, making shadows automatically use multidraw. Beware of that when testing this patch; before bevyengine#16670 lands, you'll need to manually add `GpuCulling` to your camera in order to see any performance benefits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch makes shadows use multidraw when the camera they'll be drawn to has the
GpuCullingcomponent. This results in a significant reduction in drawcalls; Bistro Exterior drops to 3 drawcalls for each shadow cascade.Note that PR #16670 will remove the
GpuCullingcomponent, making shadows automatically use multidraw. Beware of that when testing this patch; before #16670 lands, you'll need to manually addGpuCullingto your camera in order to see any performance benefits.