switch bevy_image to use wgpu-types wherever possible instead of wgpu#16620
Merged
mockersf merged 2 commits intobevyengine:mainfrom Dec 3, 2024
Merged
switch bevy_image to use wgpu-types wherever possible instead of wgpu#16620mockersf merged 2 commits intobevyengine:mainfrom
mockersf merged 2 commits intobevyengine:mainfrom
Conversation
This was referenced Dec 3, 2024
Contributor
Author
|
Those 3 are the only types which need moving. Once these merge we will be able to only pull in wgpu-types for bevy_image and bevy_mesh (and soon bevy_camera) |
Contributor
Author
|
All PRs have been merged, this will be good to go next wgpu release. |
kristoff3r
approved these changes
Dec 3, 2024
| bitflags = { version = "2.3", features = ["serde"] } | ||
| bytemuck = { version = "1.5" } | ||
| wgpu-types = { version = "23", default-features = false } | ||
| wgpu = { version = "23.0.1", default-features = false } |
Contributor
There was a problem hiding this comment.
Reminder to remember to remove this
Contributor
Author
There was a problem hiding this comment.
can't remove it this PR, but once we upgrade wgpu we can
mockersf
reviewed
Dec 3, 2024
Co-authored-by: François Mockers <[email protected]>
mockersf
approved these changes
Dec 3, 2024
ecoskey
pushed a commit
to ecoskey/bevy
that referenced
this pull request
Jan 6, 2025
…bevyengine#16620) # Objective - dont depend on wgpu if we dont have to ## Solution - works towards this, but doesnt fully accomplish it. the remaining types stopping us from doing this need to be moved upstream, i will PR this ## Testing - 3d_scene runs --------- Co-authored-by: François Mockers <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Testing