Make StateTransitionSteps public#16612
Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom Dec 3, 2024
Phoqinu:main
Merged
Make StateTransitionSteps public#16612alice-i-cecile merged 1 commit intobevyengine:mainfrom Phoqinu:main
StateTransitionSteps public#16612alice-i-cecile merged 1 commit intobevyengine:mainfrom
Phoqinu:main
Conversation
Contributor
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
alice-i-cecile
added
C-Usability
alice-i-cecile
approved these changes
Dec 3, 2024
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
Agreed: system sets should be public by default.
alice-i-cecile
added
D-Trivial
MiniaczQ
approved these changes
Dec 3, 2024
mockersf
pushed a commit
that referenced
this pull request
Jan 3, 2025
# Objective - Fixes #16594 ## Solution - `StateTransitionSteps` was made public ## Testing - _Did you test these changes? If so, how?_ I am now able to import it and use it. --- ## Showcase - Users can now write their own state scoped resources ```rust fn init_state_scoped_resource<R: Resource + FromWorld>( &mut self, state: impl States, ) -> &mut Self { use bevy::state::state::StateTransitionSteps; // this PR in action self.add_systems( StateTransition, ( clear_state_scoped_resource_impl::<_, R>(state.clone()) .in_set(StateTransitionSteps::ExitSchedules), // and here init_state_scoped_resource_impl::<_, R>(state) .in_set(StateTransitionSteps::EnterSchedules), // here too ), ); self } ```
ecoskey
pushed a commit
to ecoskey/bevy
that referenced
this pull request
Jan 6, 2025
# Objective - Fixes bevyengine#16594 ## Solution - `StateTransitionSteps` was made public ## Testing - _Did you test these changes? If so, how?_ I am now able to import it and use it. --- ## Showcase - Users can now write their own state scoped resources ```rust fn init_state_scoped_resource<R: Resource + FromWorld>( &mut self, state: impl States, ) -> &mut Self { use bevy::state::state::StateTransitionSteps; // this PR in action self.add_systems( StateTransition, ( clear_state_scoped_resource_impl::<_, R>(state.clone()) .in_set(StateTransitionSteps::ExitSchedules), // and here init_state_scoped_resource_impl::<_, R>(state) .in_set(StateTransitionSteps::EnterSchedules), // here too ), ); self } ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
StateTransitionStepspublic for better ergonomics of State Scoped Resources #16594Solution
StateTransitionStepswas made publicTesting
I am now able to import it and use it.
Showcase