Remove the min and max fields from LayoutContext.#16459
Merged
alice-i-cecile merged 2 commits intobevyengine:mainfrom Dec 3, 2024
Merged
Remove the min and max fields from LayoutContext.#16459alice-i-cecile merged 2 commits intobevyengine:mainfrom
min and max fields from LayoutContext.#16459alice-i-cecile merged 2 commits intobevyengine:mainfrom
Conversation
…eem to make any sense to cache these values, better to just use the `min_element` and `max_element` methods on the `physical_size` field.
ickshonpe
added
A-UI
rparrett
added
the
M-Migration-Guide
Contributor
|
It looks like your PR is a breaking change, but you didn't provide a migration guide. Could you add some context on what users should update when this change get released in a new version of Bevy? |
ickshonpe
added
the
C-Code-Quality
alice-i-cecile
approved these changes
Nov 22, 2024
alice-i-cecile
added
the
S-Ready-For-Final-Review
BenjaminBrienen
approved these changes
Nov 22, 2024
doup
approved these changes
Nov 25, 2024
ecoskey
pushed a commit
to ecoskey/bevy
that referenced
this pull request
Jan 6, 2025
…6459) # Objective Remove the `min` and `max` fields from `LayoutContext`. It doesn't seem useful to cache these values, it's simpler just to call `min_element` and `max_element` on the `physical_size` field. ## Migration Guide The `min` and `max` fields have been removed from `LayoutContext`. To retrieve these values call `min_element` and `max_element` on `LayoutContent::physical_size` instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Remove the
minandmaxfields fromLayoutContext.It doesn't seem useful to cache these values, it's simpler just to call
min_elementandmax_elementon thephysical_sizefield.
Migration Guide
The
minandmaxfields have been removed fromLayoutContext. To retrieve these values callmin_elementandmax_elementonLayoutContent::physical_sizeinstead.