Add missing exports in bevy_ecs#16415
Merged
mockersf merged 2 commits intobevyengine:mainfrom Nov 17, 2024
Merged
Conversation
ItsDoot
added
D-Trivial
mockersf
approved these changes
Nov 17, 2024
Member
|
you made them public so they should be documented, after that it's good to go 🙂 |
mockersf
approved these changes
Nov 17, 2024
mockersf
pushed a commit
that referenced
this pull request
Nov 17, 2024
# Objective Seemed to have missed the export of `DynamicComponentFetch` from #15593. `TryFromFilteredError` which is returned by `impl TryFrom<FiliteredEntityMut/Ref> for EntityRef/Mut` also seemed to have been missing. ## Solution Export both of them.
ecoskey
pushed a commit
to ecoskey/bevy
that referenced
this pull request
Dec 2, 2024
# Objective Seemed to have missed the export of `DynamicComponentFetch` from bevyengine#15593. `TryFromFilteredError` which is returned by `impl TryFrom<FiliteredEntityMut/Ref> for EntityRef/Mut` also seemed to have been missing. ## Solution Export both of them.
ecoskey
pushed a commit
to ecoskey/bevy
that referenced
this pull request
Jan 6, 2025
# Objective Seemed to have missed the export of `DynamicComponentFetch` from bevyengine#15593. `TryFromFilteredError` which is returned by `impl TryFrom<FiliteredEntityMut/Ref> for EntityRef/Mut` also seemed to have been missing. ## Solution Export both of them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Seemed to have missed the export of
DynamicComponentFetchfrom #15593.TryFromFilteredErrorwhich is returned byimpl TryFrom<FiliteredEntityMut/Ref> for EntityRef/Mutalso seemed to have been missing.Solution
Export both of them.