Move all_tuples to a new crate#16161
Merged
alice-i-cecile merged 3 commits intobevyengine:mainfrom Dec 3, 2024
Merged
Conversation
BenjaminBrienen
added
S-Blocked
Contributor
Author
|
Blocked on the creation of the bevyengine repository. |
BenjaminBrienen
changed the title
all_tuples to a new crate
alice-i-cecile
removed
the
S-Blocked
alice-i-cecile
approved these changes
Nov 7, 2024
alice-i-cecile
added
the
S-Needs-Review
bushrat011899
approved these changes
Nov 7, 2024
Contributor
bushrat011899
left a comment
bushrat011899
left a comment
There was a problem hiding this comment.
Nice to make bevy_utils even slimmer!
bushrat011899
added
S-Ready-For-Final-Review
alice-i-cecile
added
the
M-Migration-Guide
BenjaminBrienen
removed
the
S-Ready-For-Final-Review
ecoskey
pushed a commit
to ecoskey/bevy
that referenced
this pull request
Jan 6, 2025
# Objective Fixes bevyengine#15941 ## Solution Created https://crates.io/crates/variadics_please and moved the code there; updating references `bevy_utils/macros` is deleted. ## Testing cargo check ## Migration Guide Use `variadics_please::{all_tuples, all_tuples_with_size}` instead of `bevy::utils::{all_tuples, all_tuples_with_size}`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #15941
Solution
Created https://crates.io/crates/variadics_please and moved the code there; updating references
bevy_utils/macrosis deleted.Testing
cargo check
Migration Guide
Use
variadics_please::{all_tuples, all_tuples_with_size}instead ofbevy::utils::{all_tuples, all_tuples_with_size}.