Skip to content

Comments

Update notify-debouncer-full requirement from 0.3.1 to 0.4.0#16133

Merged
alice-i-cecile merged 4 commits intobevyengine:mainfrom
mnmaita:mnmaita/notify-debouncer-full-0.4.0
Oct 28, 2024
Merged

Update notify-debouncer-full requirement from 0.3.1 to 0.4.0#16133
alice-i-cecile merged 4 commits intobevyengine:mainfrom
mnmaita:mnmaita/notify-debouncer-full-0.4.0

Conversation

@mnmaita
Copy link
Member

@mnmaita mnmaita commented Oct 28, 2024

Objective

Solution

Testing

  • CI checks passing locally

@mnmaita mnmaita added A-Assets Load files from disk to use for things like images, models, and sounds C-Dependencies A change to the crates that Bevy depends on S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 28, 2024
@mnmaita
Copy link
Member Author

mnmaita commented Oct 28, 2024

I checked and RecommendedCache translates to NoCache on Linux (and Android), and to FileIdMap on other platforms. Unsure if we need to add a comment regarding this somewhere.

@mnmaita mnmaita force-pushed the mnmaita/notify-debouncer-full-0.4.0 branch from effffc0 to e1444a5 Compare October 28, 2024 12:43
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 28, 2024
@alice-i-cecile alice-i-cecile added this to the 0.15 milestone Oct 28, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 28, 2024
Merged via the queue into bevyengine:main with commit 72321ca Oct 28, 2024
@mnmaita mnmaita deleted the mnmaita/notify-debouncer-full-0.4.0 branch October 29, 2024 09:58
mockersf pushed a commit that referenced this pull request Nov 5, 2024
# Objective

- Supersedes #16126 

## Solution

- Updated code in `file_watcher.rs` to fix breaking changes introduced
in the new version.
- Check changelog here:
https://github.com/notify-rs/notify/blob/main/CHANGELOG.md#debouncer-full-040-2024-10-25.
- Relevant PR with the breaking change:
notify-rs/notify#557.

## Testing

- CI checks passing locally

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Assets Load files from disk to use for things like images, models, and sounds C-Dependencies A change to the crates that Bevy depends on S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants