Skip to content

Fix typos in config_fast_builds.toml#16025

Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom
benfrankel:patch-3
Oct 20, 2024
Merged

Fix typos in config_fast_builds.toml#16025
alice-i-cecile merged 1 commit intobevyengine:mainfrom
benfrankel:patch-3

Conversation

@benfrankel
Copy link
Copy Markdown
Contributor

@benfrankel benfrankel commented Oct 20, 2024

From TheBevyFlock/bevy_new_2d#317 plus a few other changes.

@benfrankel benfrankel mentioned this pull request Oct 20, 2024
Merged
@mockersf
Copy link
Copy Markdown
Member

mockersf commented Oct 20, 2024

do you know why this file isn't checked by the typo CI?

@benfrankel
Copy link
Copy Markdown
Contributor Author

benfrankel commented Oct 20, 2024 •
edited
Loading

CI uses the crate-ci/typos action, which has info on this in its FAQ: https://github.com/crate-ci/typos?tab=readme-ov-file#why-was--not-corrected

EDIT: Following this, it seems we have ignore-hidden set to true (which is the default value) so typos skips the .cargo/ directory.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 20, 2024
@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Oct 20, 2024
@mockersf
Copy link
Copy Markdown
Member

mockersf commented Oct 20, 2024

EDIT: Following this, it seems we have ignore-hidden set to true (which is the default value) so typos skips the .cargo/ directory.

Thanks!

I think it could be worth a try to check if disabling that doesn't raise too many issues

@benfrankel
Copy link
Copy Markdown
Contributor Author

benfrankel commented Oct 20, 2024 •
edited
Loading

I think it could be worth a try to check if disabling that doesn't raise too many issues

The output seems good to me if we also explicitly exclude .git. I can make a separate PR for this. EDIT: #16035

@benfrankel benfrankel mentioned this pull request Oct 20, 2024
Merged
Merged via the queue into bevyengine:main with commit bad98f6 Oct 20, 2024
@benfrankel benfrankel deleted the patch-3 branch October 20, 2024 17:20
github-merge-queue bot pushed a commit that referenced this pull request Oct 20, 2024
@benfrankel
Typo-check .hidden files (#16035)
b0fd3d5 
# Objective

Typo-check .hidden files like `.cargo/config_fast_builds.toml` and
`.github/*`. Context: #16025.

## Solution

- Add `ignore-hidden = false` to `typos.toml` to override the default
value of `true`.
- Add an exception to keep `.git/` ignored in `typos.toml`.
- Fix newly-found typos so CI passes.

## Testing

Running `typos` locally finds no further typos.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mockersf mockersf mockersf approved these changes

+1 more reviewer

@MiniaczQ MiniaczQ MiniaczQ approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@benfrankel @mockersf @MiniaczQ @alice-i-cecile