Skip to content

Feature gate bevy_remote http transport.#16019

Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom
LiamGallagher737:brp-http-feature-gate
Oct 20, 2024
Merged

Feature gate bevy_remote http transport.#16019
alice-i-cecile merged 1 commit intobevyengine:mainfrom
LiamGallagher737:brp-http-feature-gate

Conversation

@LiamGallagher737
Copy link
Copy Markdown
Member

Objective

Be able to depend on the crate for the types without bringing in smol-hyper and other http dependencies.

Solution

Create a new HTTP feature that is enabled by default.

@LiamGallagher737 LiamGallagher737 added C-Feature A new feature, making something new possible D-Trivial Nice and easy! A great choice to get started with Bevy A-Dev-Tools Tools used to debug Bevy applications. S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 20, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 20, 2024
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 20, 2024
Merged via the queue into bevyengine:main with commit 26a5f7f Oct 20, 2024
@LiamGallagher737 LiamGallagher737 deleted the brp-http-feature-gate branch October 20, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Dev-Tools Tools used to debug Bevy applications. C-Feature A new feature, making something new possible D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants