Mute unreachable patterns/code warnings#16012
Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom Oct 20, 2024
Merged
Conversation
alice-i-cecile
added
A-Rendering
alice-i-cecile
requested changes
Oct 20, 2024
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
Can you swap these for an expect statement with a reason? These have recently landed and they're a bit easier to maintain :)
alice-i-cecile
added
D-Trivial
When all image features are disabled, do not emit warnings. Warnings pop up when running ``` cargo check -p bevy_mesh ```
stepancheg
force-pushed
the
unreachable
branch
from
97a2841 to
a1f3ec3
Compare
Contributor
Author
|
@alice-i-cecile if you mean (Updated the PR to remove a couple incorrect/unnecessary allows). |
alice-i-cecile
added
S-Ready-For-Final-Review
alice-i-cecile
approved these changes
Oct 20, 2024
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
Ah, that makes sense. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Make compiler output more helpful when running
cargo check -p bevy_mesh. Currently it contains a lot of unreachable patterns/code warnings due to features disabled by default.Solution
Mute the warnings.
Testing
CI