Skip to content

Check examples screenshots on windows#16010

Merged
alice-i-cecile merged 3 commits intobevyengine:mainfrom
mockersf:check-examples-screenshots-on-windows
Oct 20, 2024
Merged

Check examples screenshots on windows#16010
alice-i-cecile merged 3 commits intobevyengine:mainfrom
mockersf:check-examples-screenshots-on-windows

Conversation

@mockersf
Copy link
Copy Markdown
Member

@mockersf mockersf commented Oct 19, 2024

Objective

Solution

  • Checks screenshots on Windows
  • Also disable the helmet gltf scene in windows ci as it doesn't work

@mockersf mockersf added A-Rendering Drawing game state to the screen A-Build-System Related to build systems or continuous integration O-Windows Specific to the Windows desktop operating system C-Testing A change that impacts how we test Bevy or how users test their apps labels Oct 19, 2024
@alice-i-cecile alice-i-cecile added the S-Needs-Review Needs reviewer attention (from anyone!) to move forward label Oct 20, 2024
@alice-i-cecile alice-i-cecile requested a review from BD103 October 20, 2024 14:23
@alice-i-cecile alice-i-cecile added the D-Straightforward Simple bug fixes and API improvements, docs, test and examples label Oct 20, 2024
BD103
BD103 approved these changes Oct 20, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@BD103 BD103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@BD103 BD103 added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 20, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 20, 2024
Merged via the queue into bevyengine:main with commit ec26842 Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

+1 more reviewer

@BD103 BD103 BD103 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Build-System Related to build systems or continuous integration A-Rendering Drawing game state to the screen C-Testing A change that impacts how we test Bevy or how users test their apps D-Straightforward Simple bug fixes and API improvements, docs, test and examples O-Windows Specific to the Windows desktop operating system S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

No open projects
Rendering (Old)
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mockersf @alice-i-cecile @BD103