Skip to content

Fix animation_masks example's buttons#15996

Merged
mockersf merged 1 commit intobevyengine:mainfrom
rparrett:fix-animation-masks
Oct 19, 2024
Merged

Fix animation_masks example's buttons#15996
mockersf merged 1 commit intobevyengine:mainfrom
rparrett:fix-animation-masks

Conversation

@rparrett
Copy link
Copy Markdown
Contributor

@rparrett rparrett commented Oct 18, 2024

Objective

Fixes #15995

Solution

Corrects a mistake made during the example migration in #15591.

AnimationControl was meant to be on the parent, not the child. So the query in update_ui was no longer matching.

Testing

cargo run --example animation_masks

@rparrett rparrett changed the title Fix animation_masks buttons Fix animation_masks example's buttons Oct 18, 2024
@rparrett rparrett added D-Trivial Nice and easy! A great choice to get started with Bevy C-Examples An addition or correction to our examples A-Animation Make things move and change over time C-Bug An unexpected or incorrect behavior labels Oct 18, 2024
@tim-blackbird tim-blackbird added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Oct 18, 2024
@mockersf mockersf added this pull request to the merge queue Oct 18, 2024
Merged via the queue into bevyengine:main with commit c65f292 Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Animation Make things move and change over time C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Buttons on example animation_masks does not work on main (624f573443f6bd6bb8bcf716fb1289d66a15b35b)

4 participants