Merged
Conversation
IQuick143
added
C-Feature
alice-i-cecile
added
the
D-Straightforward
alice-i-cecile
approved these changes
Oct 19, 2024
IQuick143
reviewed
Oct 19, 2024
Contributor
|
O(n*log_9999999(n)) I guess |
BenjaminBrienen
approved these changes
Oct 31, 2024
mnmaita
added
S-Ready-For-Final-Review
alice-i-cecile
approved these changes
Dec 10, 2024
Contributor
|
I think this may have broken the test that checks to ensure that |
This was referenced Dec 10, 2024
pcwalton
added a commit
to pcwalton/bevy
that referenced
this pull request
Dec 10, 2024
CI was failing because `bevy_math` no longer compiled with `libcore`. This was due to PR bevyengine#15981. This commit fixes the issue by moving the applicable functionality behind `#[cfg(feature = "alloc")]`.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 10, 2024
CI was failing because `bevy_math` no longer compiled with `libcore`. This was due to PR #15981. This commit fixes the issue by moving the applicable functionality behind `#[cfg(feature = "alloc")]`.
BD103
pushed a commit
to BD103/bevy
that referenced
this pull request
Dec 10, 2024
# Objective - This PR adds the ability to determine whether a `Polygon<N>` or `BoxedPolygon` is simple (aka. not self-intersecting) by calling `my_polygon.is_simple()`. - This may be useful information for users to determine whether their polygons are 'valid' and will be useful when adding meshing for polygons. - As such this is a step towards fixing bevyengine#15255 ## Solution - Implemented the Shamos-Hoey algorithm in its own module `polygon`. ## Testing - Tests are included, and can be verified visually. --- ## Performance - The Shamos-Hoey algorithm runs in O(n * log n) - In reality, the results look more linear to me. - Determining simplicity for a simple polygon (the worst case) with less than 100 vertices takes less than 0.2ms. 
BD103
pushed a commit
to BD103/bevy
that referenced
this pull request
Dec 10, 2024
…ine#16739) CI was failing because `bevy_math` no longer compiled with `libcore`. This was due to PR bevyengine#15981. This commit fixes the issue by moving the applicable functionality behind `#[cfg(feature = "alloc")]`.
ecoskey
pushed a commit
to ecoskey/bevy
that referenced
this pull request
Jan 6, 2025
# Objective - This PR adds the ability to determine whether a `Polygon<N>` or `BoxedPolygon` is simple (aka. not self-intersecting) by calling `my_polygon.is_simple()`. - This may be useful information for users to determine whether their polygons are 'valid' and will be useful when adding meshing for polygons. - As such this is a step towards fixing bevyengine#15255 ## Solution - Implemented the Shamos-Hoey algorithm in its own module `polygon`. ## Testing - Tests are included, and can be verified visually. --- ## Performance - The Shamos-Hoey algorithm runs in O(n * log n) - In reality, the results look more linear to me. - Determining simplicity for a simple polygon (the worst case) with less than 100 vertices takes less than 0.2ms. 
ecoskey
pushed a commit
to ecoskey/bevy
that referenced
this pull request
Jan 6, 2025
…ine#16739) CI was failing because `bevy_math` no longer compiled with `libcore`. This was due to PR bevyengine#15981. This commit fixes the issue by moving the applicable functionality behind `#[cfg(feature = "alloc")]`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Polygon<N>orBoxedPolygonis simple (aka. not self-intersecting) by callingmy_polygon.is_simple().Solution
polygon.Testing
Performance