Fix typos from greyscale -> grayscale#15947
Merged
mockersf merged 1 commit intobevyengine:mainfrom Oct 16, 2024
Merged
Conversation
I was grepping grayscale and thought I'd fix these while I'm here so I don't need to look for both forms.
Jondolf
approved these changes
Oct 16, 2024
Contributor
Jondolf
left a comment
There was a problem hiding this comment.
Bevy uses American English, so this makes sense
tim-blackbird
approved these changes
Oct 16, 2024
mockersf
approved these changes
Oct 16, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 20, 2024
# Objective Bevy seems to want to standardize on "American English" spellings. Not sure if this is laid out anywhere in writing, but see also #15947. While perusing the docs for `typos`, I noticed that it has a `locale` config option and tried it out. ## Solution Switch to `en-us` locale in the `typos` config and run `typos -w` ## Migration Guide The following methods or fields have been renamed from `*dependants*` to `*dependents*`. - `ProcessorAssetInfo::dependants` - `ProcessorAssetInfos::add_dependant` - `ProcessorAssetInfos::non_existent_dependants` - `AssetInfo::dependants_waiting_on_load` - `AssetInfo::dependants_waiting_on_recursive_dep_load` - `AssetInfos::loader_dependants` - `AssetInfos::remove_dependants_and_labels`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
I was grepping for "grayscale" and thought I'd fix these while I'm here so I don't need to look for both forms.
Solution
From wikipedia: