Skip to content

Fix typos from greyscale -> grayscale#15947

Merged
mockersf merged 1 commit intobevyengine:mainfrom
mgi388:graescale
Oct 16, 2024
Merged

Fix typos from greyscale -> grayscale#15947
mockersf merged 1 commit intobevyengine:mainfrom
mgi388:graescale

Conversation

@mgi388
Copy link
Copy Markdown
Contributor

@mgi388 mgi388 commented Oct 16, 2024

Objective

I was grepping for "grayscale" and thought I'd fix these while I'm here so I don't need to look for both forms.

Solution

From wikipedia:

In digital photography, computer-generated imagery, and colorimetry, a greyscale (more common in Commonwealth English) or grayscale (more common in American English)

I was grepping grayscale and thought I'd fix these while I'm here so I
don't need to look for both forms.
Copy link
Copy Markdown
Contributor

@Jondolf Jondolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bevy uses American English, so this makes sense

@mockersf mockersf added this pull request to the merge queue Oct 16, 2024
Merged via the queue into bevyengine:main with commit 87c33da Oct 16, 2024
@mgi388 mgi388 deleted the graescale branch October 16, 2024 23:14
github-merge-queue bot pushed a commit that referenced this pull request Oct 20, 2024
# Objective

Bevy seems to want to standardize on "American English" spellings. Not
sure if this is laid out anywhere in writing, but see also #15947.

While perusing the docs for `typos`, I noticed that it has a `locale`
config option and tried it out.

## Solution

Switch to `en-us` locale in the `typos` config and run `typos -w`

## Migration Guide

The following methods or fields have been renamed from `*dependants*` to
`*dependents*`.

- `ProcessorAssetInfo::dependants`
- `ProcessorAssetInfos::add_dependant`
- `ProcessorAssetInfos::non_existent_dependants`
- `AssetInfo::dependants_waiting_on_load`
- `AssetInfo::dependants_waiting_on_recursive_dep_load`
- `AssetInfos::loader_dependants`
- `AssetInfos::remove_dependants_and_labels`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants