Closed
Conversation
Open
Davier
reviewed
Mar 9, 2021
Contributor
Davier
left a comment
Davier
left a comment
There was a problem hiding this comment.
You probably need to handle removed components with a second exclusive system in the last stage
| } | ||
| pub struct ActiveIndexed<'a, T: Component + Eq + Hash + Clone> { | ||
| indexed: &'a mut Indexed<'a, T>, | ||
| orig_value: T, |
Contributor
There was a problem hiding this comment.
It would be better to store its hash instead and drop the Clone bound, but HashMap::raw_entry() is not stable. Maybe we could use hashbrown: https://docs.rs/hashbrown/0.9.1/hashbrown/hash_map/struct.HashMap.html#method.raw_entry_mut
alice-i-cecile
added
the
S-Needs-Design-Doc
cart
added
the
S-Pre-Relicense
mockersf
removed
the
S-Pre-Relicense
Member
Author
|
Closing, might reimplement in a separate PR once #2254 lands. |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Indexing is a highly requested feature (#1205) that we currently don't have an answer to. This PR implements one possible version of indexing, by eagerly updating the index to ensure it's always valid.