Merged
Conversation
alice-i-cecile
added
C-Dependencies
Contributor
|
It looks like your PR is a breaking change, but you didn't provide a migration guide. Could you add some context on what users should update when this change get released in a new version of Bevy? |
rparrett
suggested changes
Oct 11, 2024
Contributor
Author
|
Nits addressed |
rparrett
approved these changes
Oct 12, 2024
rparrett
added
S-Ready-For-Final-Review
This was referenced Oct 28, 2024
mnmaita
approved these changes
Oct 28, 2024
BenjaminBrienen
approved these changes
Oct 28, 2024
Contributor
|
fixes #16304 |
Contributor
Author
|
@alice-i-cecile can we can merge this now 0.15 has been released? |
Member
|
Yep! I'll grab this in my next merge train. |
ecoskey
pushed a commit
to ecoskey/bevy
that referenced
this pull request
Jan 6, 2025
# Objective - Keep Taffy version up to date Taffy 0.6 doesn't include a huge amount relevant to Bevy. But it does: - Add the `box_sizing` style - Expose the computed `margin` in layout - Traitifies the `Style` struct, which opens up the possibility of using Bevy's `Style` struct directly (although Bevy currently does some style resolution at conversion time which would no longer be cached if it was used directly). - Have a few bug fixes in the layout algorithms ## Solution - Upgrade Taffy to `0.6.0` ## Testing - I've run the `grid` example. All looks good. - More testing is probably warranted. We have had regressions from Taffy upgrades before - Having said that, most of the algorithm changes this cycle were driven by fixing WPT tests run through the new Servo integration. So they're possibly less likely than usual to cause regressions. ## Breaking changes The only "breaking" change is adding a field to `Style`. Probably doesn't bear mentioning? --------- Co-authored-by: Alice Cecile <[email protected]>
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Taffy 0.6 doesn't include a huge amount relevant to Bevy. But it does:
box_sizingstylemarginin layoutStylestruct, which opens up the possibility of using Bevy'sStylestruct directly (although Bevy currently does some style resolution at conversion time which would no longer be cached if it was used directly).Solution
0.6.0Testing
gridexample. All looks good.Breaking changes
The only "breaking" change is adding a field to
Style. Probably doesn't bear mentioning?