Add convenience methods for constructing and setting storage buffer data#15044
Merged
alice-i-cecile merged 3 commits intobevyengine:mainfrom Sep 9, 2024
Merged
Conversation
…ata from ShaderType.
tychedelia
added
C-Feature
brianreavis
suggested changes
Sep 5, 2024
Contributor
brianreavis
left a comment
brianreavis
left a comment
There was a problem hiding this comment.
Here are some adjustments to reduce copying
brianreavis
approved these changes
Sep 5, 2024
janhohenheim
added
S-Ready-For-Final-Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds some methods to assist in building
ShaderStorageBufferwithout usingbytemuck. We keep the&[u8]constructors since this is still modeled as a thin wrapper around the buffer descriptor, but should make it easier to interact with at the cost of an extra allocation in theShaderTypepath for the buffer writer.Follow up from #14663