Ensure more explicit system ordering for preparing view target.#15000
Merged
alice-i-cecile merged 2 commits intobevyengine:mainfrom Aug 31, 2024
Merged
Conversation
tychedelia
added
C-Bug
Member
|
This is a plausible fix: the referenced behavior matches that of system order ambiguities, only appearing on some runs. |
alice-i-cecile
added
S-Ready-For-Final-Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14993 (maybe). Adds a system ordering constraint that was missed in the refactor in #14833. The theory here is that the single threaded forces a topology that causes the prepare system to run before
prepare_windowsin a way that causes issues. For whatever reason, this appears to be unlikely when multi-threading is enabled.