Opportunistically use dense iter for archetypal iteration in Par_iter#14673
Merged
alice-i-cecile merged 7 commits intobevyengine:mainfrom Sep 3, 2024
Merged
Opportunistically use dense iter for archetypal iteration in Par_iter#14673alice-i-cecile merged 7 commits intobevyengine:mainfrom
alice-i-cecile merged 7 commits intobevyengine:mainfrom
Conversation
alice-i-cecile
added
A-ECS
alice-i-cecile
added
the
M-Release-Note
Member
|
Dang, those are some impressive numbers. |
chescock
approved these changes
Aug 9, 2024
NthTensor
approved these changes
Sep 3, 2024
Contributor
NthTensor
left a comment
NthTensor
left a comment
There was a problem hiding this comment.
I don't feel qualified to approve the code but I did replicate the results.
alice-i-cecile
added
S-Ready-For-Final-Review
13ros27
approved these changes
Sep 3, 2024
Contributor
13ros27
left a comment
13ros27
left a comment
There was a problem hiding this comment.
This looks good to me, I didn't run the benchmarks or scrutinise them very much but I trust your and Nths numbers. The comments are very clear and easy to follow so thank you for those, nice bit of deduplication too.
alice-i-cecile
approved these changes
Sep 3, 2024
Member
|
Thank you to everyone involved with the authoring or reviewing of this PR! This work is relatively important and needs release notes! Head over to bevyengine/bevy-website#1682 if you'd like to help out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Performance
no performance regression for regular itertaion
3.5X faster in hybrid parallel iteraion,this number is far greater than the benefits obtained in regular iteration(~1.81) because mutable iterations on continuous memory can effectively reduce the cost of mataining core cache coherence