fix examples after the switch for msaa to a component#14446
Merged
mockersf merged 1 commit intobevyengine:mainfrom Jul 24, 2024
Merged
fix examples after the switch for msaa to a component#14446mockersf merged 1 commit intobevyengine:mainfrom
mockersf merged 1 commit intobevyengine:mainfrom
Conversation
mnmaita
approved these changes
Jul 23, 2024
janhohenheim
approved these changes
Jul 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Move
Msaato component #14273 changed MSAA to a component, and broke some examplesSSAO needs MSAA to be disabled
bevy/crates/bevy_pbr/src/ssao/mod.rs
Line 495 in f0ff7fb
AlphaMode::AlphaToCoverageneeds MSAA to be not off to do somethingbevy/examples/3d/transparency_3d.rs
Lines 113 to 117 in f0ff7fb
Solution