Set scissor on upscale to match camera viewport#14287
Merged
mockersf merged 5 commits intobevyengine:mainfrom Jul 20, 2024
Merged
Set scissor on upscale to match camera viewport#14287mockersf merged 5 commits intobevyengine:mainfrom
mockersf merged 5 commits intobevyengine:mainfrom
Conversation
By setting the gpu scissor on views that have a configured viewport, we can avoid the need to set complicated clear color configs. This is particularly helpful if the user is using mixed hdr (or msaa in the future).
BD103
added
C-Feature
This was referenced Jul 19, 2024
paul-hansen
approved these changes
Jul 19, 2024
paul-hansen
added a commit
to paul-hansen/bevy
that referenced
this pull request
Jul 19, 2024
tychedelia
added
S-Needs-Review
paul-hansen
reviewed
Jul 19, 2024
tychedelia
changed the title
paul-hansen
approved these changes
Jul 20, 2024
mockersf
approved these changes
Jul 20, 2024
mmatvein
pushed a commit
to SomeGameCompany/bevy
that referenced
this pull request
Aug 22, 2024
# Objective When the user renders multiple cameras to the same output texture, it can sometimes be confusing what `ClearColorConfig` is necessary for each camera to avoid overwriting the previous camera's output. This is particular true in cases where the user uses mixed HDR cameras, which means that their scene is being rendered to different internal textures. ## Solution When a view has a configured viewport, set the GPU scissor in the upscaling node so we don't overwrite areas that were written to by other cameras. ## Testing Ran the `split_screen` example.
mockersf
pushed a commit
that referenced
this pull request
Sep 5, 2024
# Objective When the user renders multiple cameras to the same output texture, it can sometimes be confusing what `ClearColorConfig` is necessary for each camera to avoid overwriting the previous camera's output. This is particular true in cases where the user uses mixed HDR cameras, which means that their scene is being rendered to different internal textures. ## Solution When a view has a configured viewport, set the GPU scissor in the upscaling node so we don't overwrite areas that were written to by other cameras. ## Testing Ran the `split_screen` example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
When the user renders multiple cameras to the same output texture, it can sometimes be confusing what
ClearColorConfigis necessary for each camera to avoid overwriting the previous camera's output. This is particular true in cases where the user uses mixed HDR cameras, which means that their scene is being rendered to different internal textures.Solution
When a view has a configured viewport, set the GPU scissor in the upscaling node so we don't overwrite areas that were written to by other cameras.
Testing
Ran the
split_screenexample.