add missing sort_unstable_by_key to QueryIter#14040
Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom Jun 27, 2024
Merged
Conversation
Victoronz
added
C-Feature
Contributor
Author
|
The docs, test and implementation of |
Victoronz
force-pushed
the
let-sort-unstable-by-key-join-the-release-party
branch
from
bbbf9fd to
3a04d38
Compare
Contributor
Author
|
(added missing doc mention on |
alice-i-cecile
approved these changes
Jun 26, 2024
alice-i-cecile
removed
the
P-High
cBournhonesque
approved these changes
Jun 27, 2024
alice-i-cecile
added
S-Ready-For-Final-Review
mockersf
pushed a commit
that referenced
this pull request
Jun 27, 2024
# Objective `QueryIter::sort_unstable_by_key` is missing. ## Solution Add `QueryIter::sort_unstable_by_key`. ## Testing Added the new method to existing test. ## Changelog Added `QueryIter::sort_unstable_by_key`.
zmbush
pushed a commit
to zmbush/bevy
that referenced
this pull request
Jul 3, 2024
# Objective `QueryIter::sort_unstable_by_key` is missing. ## Solution Add `QueryIter::sort_unstable_by_key`. ## Testing Added the new method to existing test. ## Changelog Added `QueryIter::sort_unstable_by_key`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
QueryIter::sort_unstable_by_keyis missing.Solution
Add
QueryIter::sort_unstable_by_key.Testing
Added the new method to existing test.
Changelog
Added
QueryIter::sort_unstable_by_key.