simple Debug impls for query iterators#13476
Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom May 22, 2024
Merged
Conversation
Victoronz
added
D-Trivial
alice-i-cecile
approved these changes
May 22, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 22, 2024
# Objective The current query iterators cannot be used in positions with a `Debug` bound. F.e. when they are packaged in `Result` in the error position, `expect` cannot be called on them. Required for `QueryManyIter::entities_all_unique` ## Solution Add simple `Debug` impls that print the query iterator names. ## Changelog `QueryIter`, `QueryManyIter`, `QueryCombinationIter`, and `QuerySortedIter` now implement `Debug`.
alice-i-cecile
added
S-Ready-For-Final-Review
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
The current query iterators cannot be used in positions with a
Debugbound.F.e. when they are packaged in
Resultin the error position,expectcannot be called on them.Required for
QueryManyIter::entities_all_uniquein #13477.Solution
Add simple
Debugimpls that print the query iterator names.Changelog
QueryIter,QueryManyIter,QueryCombinationIter, andQuerySortedIternow implementDebug.