Skip to content

fix msaa shift with irradiance volumes in mesh pipeline key#12845

Merged
mockersf merged 1 commit intobevyengine:mainfrom
mockersf:irradiance-volume-fix-sample-count
Apr 5, 2024
Merged

fix msaa shift with irradiance volumes in mesh pipeline key#12845
mockersf merged 1 commit intobevyengine:mainfrom
mockersf:irradiance-volume-fix-sample-count

Conversation

@mockersf
Copy link
Copy Markdown
Member

@mockersf mockersf commented Apr 2, 2024 •
edited
Loading

Objective

wgpu error: Validation Error

Caused by:
    In Device::create_render_pipeline
      note: label = `pbr_opaque_mesh_pipeline`
    Color state [0] is invalid
    Sample count 8 is not supported by format Rgba8UnormSrgb on this device. The WebGPU spec guarentees [1, 4] samples are supported by this format. With the TEXTURE_ADAPTER_SPECIFIC_FORMAT_FEATURES feature your device supports [1, 2, 4].

Solution

  • Shift bits a bit more

@mockersf mockersf added A-Rendering Drawing game state to the screen P-Crash A sudden unexpected crash labels Apr 2, 2024
@mockersf mockersf added this to the 0.14 milestone Apr 2, 2024
@mockersf mockersf requested a review from pcwalton April 2, 2024 06:58
@mockersf mockersf mentioned this pull request Apr 4, 2024
Closed
@pcwalton
Copy link
Copy Markdown
Contributor

pcwalton commented Apr 5, 2024

Argh, right, fencepost error.

@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Apr 5, 2024
@mockersf mockersf added this pull request to the merge queue Apr 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 5, 2024
@mockersf mockersf added this pull request to the merge queue Apr 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 5, 2024
@mockersf mockersf added this pull request to the merge queue Apr 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 5, 2024
@mockersf mockersf added this pull request to the merge queue Apr 5, 2024
Merged via the queue into bevyengine:main with commit a9964f4 Apr 5, 2024
@mockersf mockersf deleted the irradiance-volume-fix-sample-count branch May 17, 2024 21:14
@mockersf mockersf restored the irradiance-volume-fix-sample-count branch May 17, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@pcwalton pcwalton pcwalton approved these changes

@kristoff3r kristoff3r kristoff3r approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen P-Crash A sudden unexpected crash S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

0.14

Development

Successfully merging this pull request may close these issues.

Example irradiance_volumes crashing

3 participants

@mockersf @pcwalton @kristoff3r