Fix typos in insert_or_spawn_batch/spawn_batch methods#12812
Merged
james7132 merged 1 commit intobevyengine:mainfrom Mar 31, 2024
unknownue:fix-typos-bundles_iter
Merged
Fix typos in insert_or_spawn_batch/spawn_batch methods#12812james7132 merged 1 commit intobevyengine:mainfrom unknownue:fix-typos-bundles_iter
james7132 merged 1 commit intobevyengine:mainfrom
unknownue:fix-typos-bundles_iter
Conversation
Contributor
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
bundlesparameter ininsert_or_spawn_batchmethod has inconsistent naming with docs (e.g.bundles_iter) since Restore support for runningfnEntityCommandson entities that might be despawned #11107.Solution
bundleswithbundles_iter, asbundles_iteris more expressive to its type.