Merged
Conversation
alice-i-cecile
added
C-Feature
alice-i-cecile
approved these changes
Mar 12, 2024
alice-i-cecile
added
the
M-Release-Note
Co-authored-by: Alice Cecile <[email protected]>
Contributor
Author
|
Apparently there is something wrong with bevy_reflect. Can someone help here? |
Member
|
#12433 should fix the CI failure :) |
pablo-lua
reviewed
Mar 12, 2024
Contributor
pablo-lua
left a comment
pablo-lua
left a comment
There was a problem hiding this comment.
Looks good, I just have a few comments
pablo-lua
approved these changes
Mar 13, 2024
pablo-lua
added
the
S-Ready-For-Final-Review
57 tasks
This was referenced May 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Changelog
gizmos.grid(...)andgizmos.grid_2d(...)now return aGridBuilder2d.gizmos.grid_3d(...)which returns aGridBuilder3d.GridBuilder3dexposes some methods for configuring the z axis while the 2d version doesn't..outer_edges_x(), etc. on the builder.Additional information
Please note that I have not added the 3d grid to any example as not to clutter them.
Here is an image of what the 3d grid looks like: