Merged
Conversation
pablo-lua
reviewed
Mar 2, 2024
Contributor
pablo-lua
left a comment
There was a problem hiding this comment.
This was what I was expecting from this feature. Though I'm not sure about the rendering part, I have a couple of maybe silly questions.
alice-i-cecile
approved these changes
Mar 5, 2024
pablo-lua
suggested changes
Mar 5, 2024
Contributor
pablo-lua
left a comment
There was a problem hiding this comment.
The render phase was a bit tricky, but everything right. There is a couple of things in other places that could improve IMO
Co-authored-by: Pablo Reinhardt <[email protected]>
Contributor
|
The CI error looks like a external error, not related to this PR. I'll have a better look now just to make sure though. |
Contributor
|
#12254 found the source of the error. I think you have to use bevy_utils for this now. |
Merged
This was referenced May 30, 2024
This was referenced Aug 8, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 9, 2024
# Objective The changes made in #12252 introduced an previously fixed bug in webgpu rendering. ## Solution This fix is based on #8910 and applies the same vertex buffer layout assignment for the LineGizmo Pipeline. ## Testing - Tested the 3D Gizmo example in webgpu and webgl environments Co-authored-by: Alice Cecile <[email protected]>
mockersf
pushed a commit
that referenced
this pull request
Sep 5, 2024
# Objective The changes made in #12252 introduced an previously fixed bug in webgpu rendering. ## Solution This fix is based on #8910 and applies the same vertex buffer layout assignment for the LineGizmo Pipeline. ## Testing - Tested the 3D Gizmo example in webgpu and webgl environments Co-authored-by: Alice Cecile <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
line_joints: GizmoLineJointtoGizmoConfig. Currently the following values are supported:GizmoLineJoint::None: does not draw line joints, same behaviour as previouslyGizmoLineJoint::Bevel: draws a single triangle between the linesGizmoLineJoint::Miter/ 'spiky joints': draws two triangles between the lines extending them until they meet at a (miter) point.GizmoLineJoint::Round(resolution): Draw a circle arc between the lines. The circle is a triangle fan ofresolutiontriangles.Changelog
GizmoLineJoint, use that inGizmoConfigand added necessary pipelines and draw commands.line_joints.wgslshader containing three vertex shadersvertex_bevel,vertex_miterandvertex_roundas well as a basicfragmentshader.Migration Guide
Any manually created
GizmoConfigs must now set the.line_jointsfield.Known issues
Additional information
Some pretty images :)
Now for a weird video:
Screen.Recording.2024-03-02.at.05.14.23.mov