Rename bevy_render::Color to LegacyColor#12069
Merged
alice-i-cecile merged 29 commits intobevyengine:mainfrom Feb 24, 2024
Merged
Rename bevy_render::Color to LegacyColor#12069alice-i-cecile merged 29 commits intobevyengine:mainfrom
bevy_render::Color to LegacyColor#12069alice-i-cecile merged 29 commits intobevyengine:mainfrom
Conversation
added 11 commits
February 23, 2024 16:46
alice-i-cecile
added
A-Rendering
viridia
approved these changes
Feb 23, 2024
cart
reviewed
Feb 24, 2024
Member
cart
left a comment
cart
left a comment
There was a problem hiding this comment.
I'm on board, minus a couple of "higher level concept" renames, which feel unnecessary to me.
Member
Author
|
Yeah, those extra renames were just a mistake. Thanks for catching them! |
Member
Author
|
Cleaned up those accidental renames, and did another pass myself in the diff view to catch any other mistakes. I think this should be good now. |
viridia
approved these changes
Feb 24, 2024
kristoff3r
approved these changes
Feb 24, 2024
pablo-lua
reviewed
Feb 24, 2024
Contributor
pablo-lua
left a comment
pablo-lua
left a comment
There was a problem hiding this comment.
did a simple pass judging just by names on every file. There is some points that I have a question about, but thats fairly simple :)
Comment on lines
62
to
63
| /// <div style="background-color:rgb(94%, 97%, 100%); width: 10px; padding: 10px; border: 1px solid;"></div> | ||
| pub const ALICE_BLUE: Color = Color::rgb(0.94, 0.97, 1.0); | ||
| pub const ALICE_BLUE: LegacyColor = LegacyColor::rgb(0.94, 0.97, 1.0); | ||
| /// <div style="background-color:rgb(98%, 92%, 84%); width: 10px; padding: 10px; border: 1px solid;"></div> |
Contributor
There was a problem hiding this comment.
is there a reason to not use Self in the type assign of this consts? could simplify further work on this area maybe.
Member
Author
There was a problem hiding this comment.
Yeah, it's not a bad choice. I wanted to keep this PR as simple as possible though.
pablo-lua
approved these changes
Feb 24, 2024
added 2 commits
February 24, 2024 16:12
alice-i-cecile
added
the
S-Ready-For-Final-Review
msvbg
pushed a commit
to msvbg/bevy
that referenced
this pull request
Feb 26, 2024
# Objective The migration process for `bevy_color` (bevyengine#12013) will be fairly involved: there will be hundreds of affected files, and a large number of APIs. ## Solution To allow us to proceed granularly, we're going to keep both `bevy_color::Color` (new) and `bevy_render::Color` (old) around until the migration is complete. However, simply doing this directly is confusing! They're both called `Color`, making it very hard to tell when a portion of the code has been ported. As discussed in bevyengine#12056, by renaming the old `Color` type, we can make it easier to gradually migrate over, one API at a time. ## Migration Guide THIS MIGRATION GUIDE INTENTIONALLY LEFT BLANK. This change should not be shipped to end users: delete this section in the final migration guide! --------- Co-authored-by: Alice Cecile <[email protected]>
msvbg
pushed a commit
to msvbg/bevy
that referenced
this pull request
Feb 26, 2024
# Objective The migration process for `bevy_color` (bevyengine#12013) will be fairly involved: there will be hundreds of affected files, and a large number of APIs. ## Solution To allow us to proceed granularly, we're going to keep both `bevy_color::Color` (new) and `bevy_render::Color` (old) around until the migration is complete. However, simply doing this directly is confusing! They're both called `Color`, making it very hard to tell when a portion of the code has been ported. As discussed in bevyengine#12056, by renaming the old `Color` type, we can make it easier to gradually migrate over, one API at a time. ## Migration Guide THIS MIGRATION GUIDE INTENTIONALLY LEFT BLANK. This change should not be shipped to end users: delete this section in the final migration guide! --------- Co-authored-by: Alice Cecile <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
The migration process for
bevy_color(#12013) will be fairly involved: there will be hundreds of affected files, and a large number of APIs.Solution
To allow us to proceed granularly, we're going to keep both
bevy_color::Color(new) andbevy_render::Color(old) around until the migration is complete.However, simply doing this directly is confusing! They're both called
Color, making it very hard to tell when a portion of the code has been ported.As discussed in #12056, by renaming the old
Colortype, we can make it easier to gradually migrate over, one API at a time.Migration Guide
THIS MIGRATION GUIDE INTENTIONALLY LEFT BLANK.
This change should not be shipped to end users: delete this section in the final migration guide!