Call a TextureAtlasLayout a layout and not an atlas#11783
Merged
alice-i-cecile merged 2 commits intobevyengine:mainfrom Feb 13, 2024
Merged
Call a TextureAtlasLayout a layout and not an atlas#11783alice-i-cecile merged 2 commits intobevyengine:mainfrom
alice-i-cecile merged 2 commits intobevyengine:mainfrom
Conversation
Kanabenki
added
C-Docs
Member
|
@CptPotato I'd like your review here please :) |
alice-i-cecile
approved these changes
Feb 12, 2024
CptPotato
approved these changes
Feb 13, 2024
Contributor
CptPotato
left a comment
CptPotato
left a comment
There was a problem hiding this comment.
Looks good to me. More consistent and clear terminology is always nice.
Contributor
|
On the topic of consistency, I noticed I think it's usually clear what is meant here. But maybe it's worth using a single term to refer to the textures in an atlas? |
NiklasEi
added
the
S-Ready-For-Final-Review
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Member
Author
|
It failed to save screenshots from running the WASM examples. Is that a common spurious failure? |
Member
|
I haven't seen it before 🤔 Lemme try again. |
doonv
approved these changes
Feb 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the renamings/changes regarding texture atlases a bit less confusing by calling
TextureAtlasLayouta layout, not a texture atlas.