don't run create_surfaces system if not needed#11720
don't run create_surfaces system if not needed#11720mockersf merged 2 commits intobevyengine:mainfrom
create_surfaces system if not needed#11720Conversation
mockersf
added
A-Rendering
BorisBoutillier
left a comment
BorisBoutillier
left a comment
There was a problem hiding this comment.
I have checked that the create_surfaces system is effectively only run once at the beginning, so will not blocked the rendering even in Reactive mode after initial setup.
hymm
left a comment
hymm
left a comment
There was a problem hiding this comment.
Ah cool. I didn't realize that not running prepare_windows on the main thread would help with reactive low power mode + pipelined rendering. Makes sense to me after I thought abo ut it for a bit. The render thread is being told to run the last time, but is being blocked because it wants to run prepare windows on the main thread, but the main thread is asleep. We should be careful about this in the move NonSend resources PR.
Yup it's a good surprise! |
mockersf
added
the
S-Ready-For-Final-Review
# Objective - Change set of systems as I made a mistake in bevyengine#11672 - Don't block main when not needed - Fixes bevyengine#11235 ## Solution - add a run condition so that the system won't run and block main if not needed
4 participants
Objective
Solution