Allow prepare_windows to run off main thread on all platforms#11672
Merged
alice-i-cecile merged 5 commits intobevyengine:mainfrom Feb 3, 2024
Merged
Allow prepare_windows to run off main thread on all platforms#11672alice-i-cecile merged 5 commits intobevyengine:mainfrom
alice-i-cecile merged 5 commits intobevyengine:mainfrom
Conversation
mockersf
added
A-Rendering
Member
Author
|
adding to the 0.13 as a followup of #11660 |
james7132
approved these changes
Feb 3, 2024
alice-i-cecile
approved these changes
Feb 3, 2024
alice-i-cecile
added
the
S-Ready-For-Final-Review
tjamaan
pushed a commit
to tjamaan/bevy
that referenced
this pull request
Feb 6, 2024
…gine#11672) # Objective - Allow prepare windows to run off of the main thread on all platforms. - Fixes bevyengine#9964 on all platforms. ## Solution - Running `prepare_windows` on the main thread on apple platforms is only mandatory to create surface, which is only needed during window creation. Split that part into its own system that happens before `prepare_windows` - Tested on macOS and iOS --- ## Changelog - Allow prepare windows to run off main thread on all platforms.
tjamaan
pushed a commit
to tjamaan/bevy
that referenced
this pull request
Feb 6, 2024
# Objective - Change set of systems as I made a mistake in bevyengine#11672 - Don't block main when not needed - Fixes bevyengine#11235 ## Solution - add a run condition so that the system won't run and block main if not needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
prepare_windowson the main thread on apple platforms is only mandatory to create surface, which is only needed during window creation. Split that part into its own system that happens beforeprepare_windowsChangelog