Closed
Conversation
More changes. Removed unused vars. fixed warnings The above is all work done by StarArawn that I combined to make rebasing easier
missing changes from rebase
formatting fixed
Moxinilian
added
C-Feature
Member
|
Its a bit more work, but I'd appreciate it if you created a new branch from @StarArawn's branch and rebased those commits on master. That way @StarArawn gets properly attributed for their work. |
Contributor
|
Currently working on cherry-picking these commits on top of StarArawns branch. PR incoming when it's done. |
This was referenced Mar 4, 2021
Member
|
closing in favor of #1554 |
bors bot
pushed a commit
that referenced
this pull request
Mar 20, 2021
This is a rebase of StarArawns PBR work from #261 with IngmarBitters work from #1160 cherry-picked on top. I had to make a few minor changes to make some intermediate commits compile and the end result is not yet 100% what I expected, so there's a bit more work to do. Co-authored-by: John Mitchell <[email protected]> Co-authored-by: Ingmar Bitter <[email protected]>
Member
|
@IngmarBitter please see and comment in #2373 for the relicense to MIT/Apache 2.0 Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of PR #261 as stated there:
This is a WIP draft PR for adding basic PBR (Physically Based Rendering) support to bevy. It uses this as a resource for this implementation:
https://google.github.io/filament/Filament.md.html