Rename Schedule::name to Schedule::label#11531
Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom Jan 25, 2024
Merged
Rename Schedule::name to Schedule::label#11531alice-i-cecile merged 1 commit intobevyengine:mainfrom
alice-i-cecile merged 1 commit intobevyengine:mainfrom
Conversation
hymm
approved these changes
Jan 25, 2024
alice-i-cecile
added
A-ECS
alice-i-cecile
approved these changes
Jan 25, 2024
alice-i-cecile
added
the
S-Ready-For-Final-Review
tjamaan
pushed a commit
to tjamaan/bevy
that referenced
this pull request
Feb 6, 2024
# Objective While working on bevyengine#11527 I spotted that the internal field for the label of a `Schedule` is called `name`. Using `label` seems more in line with the other naming across Bevy. ## Solution Renaming the field was straightforward since it's not exposed outside of the module. This also means a changelog or migration guide isn't necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
While working on #11527 I spotted that the internal field for the label of a
Scheduleis calledname. Usinglabelseems more in line with the other naming across Bevy.Solution
Renaming the field was straightforward since it's not exposed outside of the module. This also means a changelog or migration guide isn't necessary.