Restore brightness in the remaining three examples after exposure PR#11389
Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom Jan 17, 2024
Merged
Restore brightness in the remaining three examples after exposure PR#11389alice-i-cecile merged 1 commit intobevyengine:mainfrom
alice-i-cecile merged 1 commit intobevyengine:mainfrom
Conversation
Contributor
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
alice-i-cecile
added
A-Rendering
alice-i-cecile
approved these changes
Jan 17, 2024
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
Looks good, but should we adjust the default PointLight intensity to something more reasonable?
Contributor
Author
|
@fintelia had some thoughts on that here: #8407 (comment) I didn't explicitly mention that I also felt like increasing the default PointLight intensity but I'd be down to adjust all the necessary examples again if people agree! Though, in a different PR maybe? |
Member
|
Okay, happy to leave this then. Merging as trivial :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #11376
During the development of the exposure settings PR (#11347) all examples with lighting had to be adjusted, but three were missed or simply didn't exist yet at the time. This PR restores the brightness in those examples again:
render_ui_to_texture
asset_loading
hot_asset_reloading
All of them are a bit brighter now compared to before the exposure PR, but it looks better IMO.