Skip to content

Document RegularPolygon#11017

Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom
stepancheg:regular-polygon
Jan 28, 2024
Merged

Document RegularPolygon#11017
alice-i-cecile merged 1 commit intobevyengine:mainfrom
stepancheg:regular-polygon

Conversation

@stepancheg
Copy link
Copy Markdown
Contributor

By writing a test.

For changes like #10928, it is useful to observe possible behavior change not only by running examples.

@alice-i-cecile alice-i-cecile added C-Code-Quality A section of code that is hard to understand or change A-Math Fundamental domain-agnostic mathematical operations labels Dec 18, 2023
By writing a test.
Copy link
Copy Markdown
Contributor

@jdm jdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test makes sense!

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jan 28, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 28, 2024
Merged via the queue into bevyengine:main with commit 3a2e00a Jan 28, 2024
tjamaan pushed a commit to tjamaan/bevy that referenced this pull request Feb 6, 2024
By writing a test.

For changes like bevyengine#10928, it is
useful to observe possible behavior change not only by running examples.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Math Fundamental domain-agnostic mathematical operations C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants